[cgiapp] CGI::Session

[Nicholas Bamber]

On 07/07/11 01:45, Ron Savage wrote:
> Hi Nick
> 
> On Wed, 2011-07-06 at 14:35 +0100, Nicholas Bamber wrote:
>> Ron,
>> 	You put an explicit version on every dependency. For example
>> Data::Dumper 2.128. That seems unnecessarily modern and Debian curently
>> only has 2.125. If we added the latest version as a package it might
>> need to be removed again later on.
> 
> I put in the version #s as per what I have installed.
> I'm using perlbrew & V 5.12.2.
> I'll examine how to wind back these requirements...
> I had a look at /usr/lib/perl/5.10.1/Data/Dumper.pm and it says V 2.124.
> I could do that for each pre-req.

Usually if a specific version is not required one just puts the version
as 0. I appreciate calculating these versions is hard.

> 
>> 	Also do we really need all this DBIx stuff?
> 
> The test code uses DBIx::Admin::CreateTable and DBIx::Admin::DSNManager.
> Data::Session doesn't. Of course that code could be re-written and
> included within Data::Session without those modules. I'm reluctant to do
> that, because there's already a Deb package for DBIx::Admin::CreateTable
> (that's why 'All rights reserved' was removed from the licence section
> in V 2.06), and I believe DBIx::Admin::DSNManager deserves its own Deb
> package. Nevertheless, if you think it's worth rewriting that code, feel
> free to say so.
> 
> 

In that case DBIx::Admin::DSNManager should have been in the build
requirements not the requirements.

All these problems can be worked round as the dependencies in Build.PL
are effectively advisory - except for eliminating noise. I can even give
you some feedback on minimum versions - at least to the extent your
tests capture the requirements. Also DBIx::Admin::DSNManager can be
bundled with the package at least until a separate  interest in those
develops.

-- 
Nicholas Bamber | http://www.periapt.co.uk/
PGP key 3BFFE73C from pgp.mit.edu