[cgiapp] Re: [Announce] CGI::Application::Plugin::ValidateQuery

[Mark Stosberg]

On Fri, 5 Jun 2009 15:16:43 -0400
Nathaniel Smith <nate at summersault.com> wrote:

> Greetings,
> 
> I have uploaded a plugin that provides lightweight query validation using 
> Params::Validate. The release on CPAN is stable and tested but has not seen 
> production use. Any and all feedback or review would be greatly appreciated!
> 
> http://search.cpan.org/~natek/CGI-Application-Plugin-ValidateQuery-0.99_2/lib/CGI/Application/Plugin/ValidateQuery.pm

Thanks for working on this Nathaniel. Here's a couple of initial points of feedback:

- A small thing in the POD: 
  s/If <log_level>/If C<log_level>/

- A bug: The docs say: "If you set a default, the query will be modified with the new value."
  This does not appear to be the case, for this to be true, the return value of "validate()"  
  would need to be captured, and for each value in the returned hash, a call to param()
  could be used to set the new value back in the query. 

    Mark

-- 
http://mark.stosberg.com/