[ArchEc] software review

[Thomas Krichel]

  Rishabh Sharma writes

> Repec-2009-09-13.tar.gz
>
> changed_templates::  187172
>
> unchanged_templates::  727492
>
> NEW TEMPLATES:: 13473
>
> LOST TEMPLATES:: 1376

  what excutble is used to do this?

  if it is ~/bin/read_redif, then it looks completely wrong.
  In archec at modin:~/lib/perl/ArchEc/ReDIF.pm, I read

  if ( -e $tobi_path) {
    print "File exist";
    $unchanged_templates++;
    print "\n\n\n";
    return;
  }

  If a template was prevously saved, at unchange tobi time
  it is considered to be unchanged?

  And then

else{
    print "\n";
    print "creating Directory ".$ENV{"HOME"}."/archive/".$tobi_dir;
    make_path($ENV{"HOME"}."/archive/".$tobi_dir);
    print "\n";
    print "creating tobi file ".$tobi_path;
    open FILE,">$tobi_path" or die $!;
    print FILE $template->{'TEXT'};
    #binmode(FILE);                                                                             
    #open FILE1,">$tobi_path.md5" or die $!;                                                    
    #   print FILE1 Digest::MD5->new->addfile(*FILE)->hexdigest."               $$tobi_filename\
";                                                                                              
    close FILE;
    $changed_templates ++;
    print "\n\n\n";
}

  Meanning when the file time of ReDIF file changes, 
  a new tobi file is  written? This will needlessly
  duplicate contents. 

  It looks like there is no serious attempt to distinguish between
  changed and unchanged templates by checksum. All tobis have to go
  through this check, irrespective of origin.

  Cheers,

  Thomas Krichel                    http://openlib.org/home/krichel
                                      http://authorprofile.org/pkr1
                                               skype: thomaskrichel